App Layout: Update Tabler dependency, revamp layout#55
Open
earboxer wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
I pushed it without the compiled files. Line-wise, the biggest change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #54
To test this,
npm install && npm run gulpin this project, you may also need to runphp artisan otter:installin your main project.This PR simplifies the stylesheets: No more SCSS!!! Tabler now supports dark themes, so we don't need to add any of our own code.
This changes the layout to use CSS Grid (rather than the mix of bootstrap and tabler class names).
This changes the navigation menu to use blade to create it in blade instead of in vue. (it also only appears once in the DOM instead of twice). It is not hidden behind a hamburger menu anymore for small screens).
You should test this to make sure it works: I don't have any nested menus, so it may not work with those.
With the node update, some things changed, some of which are commented out: